Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add module name #15

Open
wants to merge 1 commit into
base: zephyr
Choose a base branch
from
Open

fix: add module name #15

wants to merge 1 commit into from
+1 −0

Conversation

Jappie3
Copy link

@Jappie3 Jappie3 commented Apr 17, 2024

This MR adds the module name in zephyr/module.yml, as is stated in the official documentation:

Each Zephyr module is given a name by which it can be referred to in the build system.
The name should be specified in the zephyr/module.yml file. This will ensure the module name is not changeable through user-defined directory names or west manifest files.

de-nordic
de-nordic suggested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the Merge commit and also, is there Zephyr commit that updates the LittleFS in west.yaml of Zephyr?

@Jappie3
Copy link
Author

Jappie3 commented Oct 4, 2024

dropped the merge commit
I haven't opened a PR in the Zephyr repo yet, though if you merge my commit, won't it create an extra merge commit with a different hash?

@de-nordic
Copy link
Contributor

dropped the merge commit I haven't opened a PR in the Zephyr repo yet, though if you merge my commit, won't it create an extra merge commit with a different hash?

We have to run the "new" version of LittleFS againt Zephyr CI. Something like this PR zephyrproject-rtos/zephyr#74001, except that till this PR gets accepted you reference the LittleFS module by PR not by sha, so by something like pull/15/head.

@henrikbrixandersen
Copy link
Member

We have to run the "new" version of LittleFS againt Zephyr CI. Something like this PR zephyrproject-rtos/zephyr#74001, except that till this PR gets accepted you reference the LittleFS module by PR not by sha, so by something like pull/15/head.

The process is documented here: https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules

@Jappie3 Jappie3 mentioned this pull request Oct 4, 2024
Open
@Jappie3
Copy link
Author

Jappie3 commented Oct 4, 2024

makes sense, thanks both of you for explaining
opened zephyrproject-rtos/zephyr#79436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-nordic de-nordic de-nordic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jappie3 @de-nordic @henrikbrixandersen